r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

I think this is fine but it should get an ack from the api team

r? libs-api

Didn't have a good message to put in the attr so left it blank, still unstable so we can come back to it I guess?

This should be simple enough to figure out now, maybe something along the lines of "result does nothing unless used in a formatter".

"returns a type implementing Debug and Display, which do not have any effects unless they are used".

I think burntsushi has been taking a break from reviews

r? libs-api

"result does nothing unless used in a formatter"

Maybe "in a formatting operation"?
Though I'm not sure that's any more informative than leaving it blank, and the std has an abundance of must_uses with no message so it wouldn't be a first.

"returns a type implementing Debug and Display, which do not have any effects unless they are used".

I like that one..
I'll put it in.
Thanks!

The need to avoid "formatter" or "formatting operation" becomes obvious considering you could just call .to_string() on it, after all. (this technically does call a "formatter" but in an obscured way that people won't really think about).

@bors r+ rollup

📌 Commit 6b016d7 has been approved by dtolnay

It is now in the queue for this repository.